Fixed a bug that Chronos crashes on closing tabs just after zooming#386
Merged
Merged
Conversation
Added a logic to defer closing tabs after zooming.
HashidaTKS
force-pushed
the
fix-bug-crash-on-closing-tabs-after-zooming
branch
from
ab66dbb to
afb51d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
#384
What this PR does / why we need it:
If we close a tab within a certain period (approximately 2 seconds in the test environment) after a ZoomLevel change (like
Ctrl + +), Chronos will crash. To work around this, close operations are blocked for a fixed duration after the last ZoomLevel change.This bug was introduced by #385 .
How to verify the fixed issue:
The steps to verify:
Ctrl + +