Open
Conversation
ndr-brt
reviewed
Mar 6, 2026
Comment on lines
+55
to
+56
| assertThat(created.isSucceeded()).isTrue(); | ||
| assertThat(created.getContent()).isNotNull(); |
Collaborator
There was a problem hiding this comment.
For this test I would also ensure that id returned by the create call is the id we passed in input
Comment on lines
+66
to
+68
| assertThat(asset.isSucceeded()).isTrue(); | ||
| assertThat(asset.getContent()).isNotNull(); | ||
| assertThat(asset.getContent().id()).isEqualTo(created.getContent()); |
Collaborator
There was a problem hiding this comment.
we should verify that the data contained it's the same as what we passed in input
| var created = assets.create(shouldCreateAnAssetRequest()); | ||
| var updated = assets.update(shouldUpdateAnAssetRequest(created.getContent())); | ||
|
|
||
| assertThat(updated.isSucceeded()).isTrue(); |
Collaborator
There was a problem hiding this comment.
we should verify that the asset now has effectively changed (also by checking just a single changed attribute)
| var created = assets.create(shouldCreateAnAssetRequest()); | ||
| var deleted = assets.delete(created.getContent()); | ||
|
|
||
| assertThat(deleted.isSucceeded()).isTrue(); |
Collaborator
There was a problem hiding this comment.
We should check that the get call should return 404
| } | ||
|
|
||
| @Nested | ||
| class Async { |
Collaborator
There was a problem hiding this comment.
I think that for e2e we can just choose either sync or async and just test one of them, as we know that internally we build the request in the same way and we manage the output in the same way
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we. will add the e2e tests for the Asset service.
Closes #272