fix: fix model list refresh failed

[zhangmo8]

Summary by CodeRabbit

• Bug Fixes
  • Improved initialization and validation of provider-specific settings for enhanced stability
  • Enhanced error handling during model operations and configuration changes
  • Refined confirmation flows for model management actions

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactored ModelProviderSettingsDetail.vue initialization flow by replacing throttled/deep-watcher patterns with a provider-id-based watcher, introducing syncModels and initProviderSettings orchestration functions, and reworking Gemini safety settings initialization with improved error handling. Minor optimization added to modelStore's refreshCustomModels.

Changes

Cohort / File(s)	Summary
Model Provider Settings Refactoring src/renderer/settings/components/ModelProviderSettingsDetail.vue	Replaced throttled initialization with provider.id watcher triggering initProviderSettings; introduced syncModels function; reworked Gemini safety fetch loop with per-category error handling; updated OAuth and config handlers to re-run initialization; adjusted model enable/disable logic with confirm flag support.
Model Store Optimization src/renderer/src/stores/modelStore.ts	Added early return in refreshCustomModels when no new or existing custom models exist for the provider, bypassing unnecessary processing.

Sequence Diagram

sequenceDiagram
    participant Vue as ModelProviderSettingsDetail
    participant Watcher as Provider ID Watcher
    participant ProviderSettings as initProviderSettings
    participant Azure as Azure API
    participant Gemini as Gemini API
    participant Stores as ModelStore & ProviderStore
    
    Vue->>Watcher: Provider ID changes
    Watcher->>ProviderSettings: Trigger initialization
    
    alt Provider is Azure
        ProviderSettings->>Azure: Fetch API versions
        Azure-->>ProviderSettings: Return versions
    end
    
    alt Provider is Gemini
        ProviderSettings->>Gemini: Fetch safety levels
        Gemini-->>ProviderSettings: Return safety settings
        ProviderSettings->>ProviderSettings: Populate geminiSafetyLevels
    end
    
    ProviderSettings->>Stores: syncModels()
    Stores-->>ProviderSettings: Return populated models
    ProviderSettings->>Vue: Update UI state

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• refactor: split the Setting Store into multiple single-responsibility stores. #1101 — Replaces monolithic settings store with dedicated provider/model/ui stores and updates ModelProviderSettingsDetail component to use the new architecture.
• fix: toggle model config refresh #1086 — Modifies model refresh flow at modelStore level with changes to refreshCustomModels logic.
• fix: resolve model list synchronization issue across tabs #763 — Updates model list synchronization and model enable/disable flows in ModelProviderSettingsDetail with reactive state management.

Suggested labels

codex

Suggested reviewers

• zerob13

Poem

🐰 Hops through the model streams,
No throttle slows this flow—
Watchers guide the dreams,
From Azure depths below,
Gemini safely glows! ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: fix model list refresh failed' describes the main objective of the changeset - addressing model list refresh issues through refactoring of initialization, synchronization, and update flows in the settings component and model store.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix-model-list

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}