Ignore CSS pseudo-selector :: patterns in dependency extraction used by att_amend_desc#133
Closed
VincentGuyader with Copilot wants to merge 6 commits into
Closed
Ignore CSS pseudo-selector :: patterns in dependency extraction used by att_amend_desc#133VincentGuyader with Copilot wants to merge 6 commits into
:: patterns in dependency extraction used by att_amend_desc#133VincentGuyader with Copilot wants to merge 6 commits into
Conversation
Agent-Logs-Url: https://github.com/ThinkR-open/attachment/sessions/319ceb68-c3d2-4c15-95b8-0bd45ca20959 Co-authored-by: VincentGuyader <10470699+VincentGuyader@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThinkR-open/attachment/sessions/319ceb68-c3d2-4c15-95b8-0bd45ca20959 Co-authored-by: VincentGuyader <10470699+VincentGuyader@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThinkR-open/attachment/sessions/319ceb68-c3d2-4c15-95b8-0bd45ca20959 Co-authored-by: VincentGuyader <10470699+VincentGuyader@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ThinkR-open/attachment/sessions/319ceb68-c3d2-4c15-95b8-0bd45ca20959 Co-authored-by: VincentGuyader <10470699+VincentGuyader@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix false positives detected from CSS rules in att_amend_desc
Ignore CSS pseudo-selector Apr 19, 2026
:: patterns in dependency extraction used by att_amend_desc
Member
|
@copilot fix this |
Agent-Logs-Url: https://github.com/ThinkR-open/attachment/sessions/16289198-c761-4f4f-b380-39925762c303 Co-authored-by: VincentGuyader <10470699+VincentGuyader@users.noreply.github.com>
Author
Done in |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
att_amend_desc()was producing false dependency positives when scanning code that contains CSS selectors likelabel::after. The parser treated::inside string literals as namespace calls and extracted bogus package names.Scope
att_from_rscript()to ignorepkg::detection inside quoted string literals.library()/require()/requireNamespace()usage unchanged.Behavioral change
glue::glue()remain detected.Coverage added
tests/testthat/test-rscript.Rto assert:glue::glue()is detected.label::afterinside a CSS string is not detected.