Skip to content

Improve test suite coverage and validation#128

Merged
ThomUK merged 13 commits into
mainfrom
improve_tests
Apr 24, 2026
Merged

Improve test suite coverage and validation#128
ThomUK merged 13 commits into
mainfrom
improve_tests

Conversation

@ThomUK
Copy link
Copy Markdown
Owner

@ThomUK ThomUK commented Apr 24, 2026

Summary

  • Add edge case and boundary tests for get_target_text, get_assurance_type, get_variation_type, parse_rebase_dates, and align_rebase_dates
  • Add medium-priority tests for check_a_data, check_measure_config, check_dataset_is_complete, process_event_data_t, and lengthen_measure_data
  • Add check_for_allowed_values() helper and apply it to validate improvement_direction, unit, spc_chart_type, and aggregation against their allowed sets (with tolower normalisation)
  • Move "no date columns" guard upstream into check_a_data() so it fires at bundle entry rather than deep in lengthen_measure_data()
  • Fix copy-paste bug: check_a_data() error message incorrectly said "check_measure_data:"
  • Remove now-redundant assert_that(!any(is.na(aggregation))) check in check_report_config() — covered by check_for_allowed_values
  • Convert all test files from "description" |> test_that({}) pipe style to test_that("description", {}) for consistency

Test plan

  • devtools::test() passes with 0 failures

🤖 Generated with Claude Code

@ThomUK ThomUK merged commit 1635ad8 into main Apr 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant