v1.9.3#258
Merged
Merged
Conversation
Adjust logging across PHP and Python components to reduce debug noise and provide clearer, higher-severity alerts. Changed many debug logs to warning/info (and added context) for missing dependencies, missing parameters, device lookup failures, API/HTTP errors, AI/TTS fallbacks and other exceptions. Messages were clarified (more descriptive French texts, include UUIDs, snippets, reasons) and some log lines now include truncated excerpts to aid troubleshooting. Files modified: core/class/ttscast.class.php and resources/ttscastd/ttscastd.py.
Add new CI workflows: checkPHPCompat.yml to run PHPStan across PHP 7.4, 8.2 and 8.4 (sparse-checkout of Jeedom core and dynamic phpstan.neon generation) and checkPython.yml to run ruff on resources/ttscastd/. Minor update to checkPHP.yml to name the job for PHP 8.4. Add phpstan.neon.dist enabling reportUnmatchedIgnoredErrors and update .vscode/settings.json to ignore phpstan, PHPSTAN and shivammathur entries.
Update plugin_info/info.json to increment pluginVersion from 1.9.2 to 1.9.3 in preparation for a new release. No other changes were made.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several improvements focused on error handling, logging, and CI/CD automation for the TTS Cast plugin. The main changes include more informative and appropriately-leveled log messages (switching many from debug/error to warning/info), the addition of new GitHub Actions workflows for PHP compatibility and Python linting, and updates to ignore settings and configuration files. The plugin version is also incremented to 1.9.3.
Logging improvements and error handling:
core/class/ttscast.class.phpfromerrorordebugtowarningorinfo, and improved the clarity and detail of error messages, especially when parameters are missing or when handling dependency checks and plugin version retrieval. This makes troubleshooting easier and log outputs more meaningful. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]resources/ttscastd/ttscastd.py) to usewarninglevel instead ofdebug/errorfor missing data and HTTP errors, and to useinfofor shutdowns triggered by keyboard interrupts. [1] [2] [3] [4] [5] [6]CI/CD automation and configuration:
.github/workflows/checkPHPCompat.ymlto perform PHPStan compatibility checks for PHP versions 7.4, 8.2, and 8.4 on pull requests targeting thebetabranch..github/workflows/checkPython.ymlto run Ruff lint checks on Python code for pull requests to thebetabranch.parameters: reportUnmatchedIgnoredErrors: truetophpstan.neon.distto improve PHPStan reporting.Miscellaneous improvements:
.vscode/settings.jsonto ignore additional directories and tools related to PHPStan and the new workflows. [1] [2]plugin_info/info.jsonfrom 1.9.2 to 1.9.3.