Handle engine override in TTS options#259
Merged
Merged
Conversation
Parse per-call TTS options to detect an "engine" override and capture it in $engineOverride. Update info logs to display the effective engine (original → override) and include truncated text/file context. Remove previous debug noise and obsolete commented ding-disable logic; preserve existing daemon call behavior while improving logging and per-request engine visibility.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logging and engine override handling in the
generateTTSandplayTTSmethods ofttscast.class.php. The main focus is to improve how TTS engine overrides are detected from options and to enhance the logging for better traceability.Key improvements:
Engine override detection and logging:
generateTTSandplayTTSnow parse theenginefield from the JSON options string to detect if an engine override is requested, and this override is reflected in the log output. [1] [2]Logging enhancements:
Code cleanup: