Improve Python dependency checks and logging#276
Merged
Merged
Conversation
Enhance dependency verification and add detailed debug logs for ttscast. Replaced generic warning/info messages with structured debug entries, added explicit checks and messages for missing system packages and missing Python venv executable, and implemented counting of installed Python packages using configured regex and expected count (pythonDepString / pythonDepNum). When dependencies are missing, the code now logs the found vs expected count, the regex used, and the full pip freeze output (compressed) to aid troubleshooting. Overall behavior for setting the dependency state (ok/nok/in_progress) is preserved but with richer diagnostics.
Improve Python dependency checks and logging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves the dependency checking logic in the
dependancy_infomethod ofttscast.class.php, focusing on clearer logging and more robust diagnostics for missing Python dependencies. The updates enhance debugging and provide more detailed feedback when issues are detected.Dependency checking and logging improvements:
pip freezeto aid in debugging missing dependencies.warning/infotodebugfor all dependency-related logs, making the output more consistent and less noisy in production environments.