v1.3.19#104
Merged
Merged
Conversation
Add GitHub Actions workflows to improve CI coverage: a PHP compatibility workflow (checkPHPCompat.yml) that runs PHPStan across PHP 7.4/8.2/8.4 against a sparse clone of Jeedom Core, and a Python lint workflow (checkPython.yml) using ruff for resources/tvremoted. Also add phpstan.neon.dist to enable reportUnmatchedIgnoredErrors, and tweak existing checkPHP.yml to name the PHP lint job. Update .vscode/settings.json to include phpstan and shivammathur entries.
Introduce a configurable log level for TV-related libraries (zeroconf, androidtvremote2, adb_shell). Adds a tvLogLevel UI setting (default 'daemon' to inherit the daemon level), persists the default on install/update, passes --tvloglevel to the daemon, and applies the chosen level to the respective library loggers. Also bumps plugin version to 1.3.19 and updates zeroconf to 0.149.16.
Change several logger.debug calls to logger.info to surface important daemon events (EQRemote, EQRemoteADB, TVRemoted). Also fix a malformed pairing log format in sendBeginPairing (removed an extra placeholder) so the log arguments match the format string. These changes make scan/add/remove/pairing/close events more visible and prevent a potential logging formatting error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new configurable log level for TV libraries, improves developer tooling with new and updated CI workflows, and updates some dependencies and logging behaviors. The most important changes are summarized below.
New Feature: Configurable TV Library Log Level
tvLogLevel) that allows users to set a specific log level for TV-related Python libraries (zeroconf,androidtvremote2,adb_shell), separate from the main daemon log level. This includes updates to the configuration UI, install/update scripts, PHP daemon start command, Python argument parsing, config handling, and dynamic log level setup in the daemon. [1] [2] [3] [4] [5] [6] [7]Developer Tooling and CI Improvements
checkPHPCompat.yml) to check PHP compatibility using PHPStan across multiple PHP versions (7.4, 8.2, 8.4).checkPython.yml) to run Ruff linter on the Python codebase..vscode/settings.jsonfor improved editor experience with new tools and config keys. [1] [2]Logging Behavior Improvements
tvremoted.pyfromdebugtoinfolevel for key daemon events, device actions, and pairing processes, making logs more informative and visible at default log levels. [1] [2] [3] [4] [5] [6] [7] [8]Dependency Updates
zeroconfPython library from version 0.148.0 to 0.149.16 inrequirements.txt.Version Bump
info.json.