Open
Conversation
Docker Images BuiltImages are available for testing: # gatekeeperd
docker pull ghcr.io/tight-line/gatekeeperd:pr-23-1f92834
# gatekeeper-relay
docker pull ghcr.io/tight-line/gatekeeper-relay:pr-23-1f92834docker-compose.ymlGATEKEEPERD_IMAGE=ghcr.io/tight-line/gatekeeperd:pr-23-1f92834 \
RELAY_IMAGE=ghcr.io/tight-line/gatekeeper-relay:pr-23-1f92834 \
docker-compose --profile relay upHelm (values override)image:
repository: ghcr.io/tight-line/gatekeeperd # or gatekeeper-relay
tag: "pr-23-1f92834"Images expire ~15 days after PR closes. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Infrastructure: - Upgrade Go to 1.25.6 (fixes stdlib CVEs in net/url, net/mail, crypto/x509) - Migrate golangci-lint config to v2 format and update CI to use v2 - Add generated coverage files to .gitignore Pre-existing lint/quality fixes: - Fix unchecked m.client.Close() in redis_manager.go (errcheck) - Add shared IP address constants (testips_test.go) with NOSONAR annotations to centralize the go:S1313 hotspot review for test fixtures - Add shared string constants (testconst_test.go) for config tests - Replace ~400 duplicate string literals in handler_test.go and config_test.go with named constants, resolving SonarCloud S1192 code smells - Reduce cognitive complexity in handler_test.go by extracting test helpers
Adds a new `oidc` verifier type that validates OIDC JWT bearer tokens by fetching JWKS from the provider's discovery document and verifying RS256, RS384, RS512, ES256, ES384, and ES512 signatures.
nickmarden
force-pushed
the
feat/oidc-verifier
branch
from
8786750 to
1f92834
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
oidcverifier type that validates RS256-signed OIDC JWT bearer tokens (Authorization: Bearer <token>) from any OIDC-compliant identity providerjwks_urifrom{issuer}/.well-known/openid-configuration), standard JWK Set format, and Google X.509 certificate map formatkidtriggers a one-time cache refreshclaimsmap for additional JWT claim validation (e.g. requiringemail: chat@system.gserviceaccount.com)config/example.yaml.golangci.ymlto golangci-lint v2 config format (the linter was failing to load config entirely before this)Test plan
make testpasses with 100% coverage oninternal/verifiermake lintpasses (0 issues)make buildsucceedsconfig/example.yamlOIDC examples for correctnessdocs/PROVIDER_TODO.md— Google Chat moved to Already Implemented