fix(release): drop test step from prepublishOnly#63
Merged
Conversation
The release-please workflow intentionally skips Chromium install on the npm-token-bearing job (see release-please.yml:23-28) — but pnpm publish triggers prepublishOnly, which ran pnpm test, which needs Chromium for the Storybook browser tests. Result: every npm publish since #53 fails before uploading. Lint/typecheck/build/full-suite already ran in CI against the same commit; build:clean is sufficient publish-side gating. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
block-kitchen | 380151b | Commit Preview URL Branch Preview URL |
May 16 2026, 05:40 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm publishin the release-please workflow has been failing becauseprepublishOnlyrunspnpm test, which loads the Storybook browser tests and needs Chromium.0.6.1-alpha.0never landed on npm even though the GitHub release/tag exist.&& pnpm testfromprepublishOnlyaligns the local publish hook with the workflow's stated security stance. The full suite already ran in CI against the same commit.Test plan
0.6.1-alpha.1, since the0.6.1-alpha.0tag already exists).🤖 Generated with Claude Code