chore: improve Linux desktop compatibility diagnostics#42
Conversation
- verify.sh: neue Info-Sektion Session & Desktop (XDG_SESSION_TYPE, XDG_CURRENT_DESKTOP, WAYLAND_DISPLAY, DISPLAY), rein informativ - Clipboard-Checks session-abhängig: reine X11-Session verlangt xclip (wl-copy nur WARN), Wayland/headless verlangt wl-copy (xclip nur WARN) - ydotool fehlt: WARN statt FAIL — konsistent mit install.sh und dem Clipboard-only-Fallback der App - Hinweis, dass Fenster/Tray auch ohne input-Gruppe funktioniert - docs/setup.md: Kompatibilitätsmatrix (Kubuntu/Ubuntu/Mint/Lubuntu) als Diagnose-Referenz, ausdrücklich kein Supportversprechen - tests: 4 neue verify.sh-Tests (Session-Info, X11- vs. Wayland-Pflicht- Backend, ydotool-WARN)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e55ac5c9a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # Die App wählt das Clipboard-Backend nach Umgebung: wl-copy, wenn | ||
| # WAYLAND_DISPLAY gesetzt ist oder gar kein DISPLAY existiert; nur in einer | ||
| # reinen X11-Session (DISPLAY ohne WAYLAND_DISPLAY) ist xclip das Pflicht-Backend. | ||
| if [[ -z "${WAYLAND_DISPLAY:-}" && -n "${DISPLAY:-}" ]]; then |
There was a problem hiding this comment.
When WAYLAND_DISPLAY is set but points to no socket while DISPLAY is set, the launcher falls back to X11 by unsetting WAYLAND_DISPLAY in app/blitztext_linux.py, and PasteService then needs xclip. This new detection treats any non-empty WAYLAND_DISPLAY as Wayland, so verify.sh can fail on missing wl-copy and only warn on missing xclip even though the app will run in X11; mirror the startup normalization or validate the socket before choosing CLIPBOARD_REQUIRED.
Useful? React with 👍 / 👎.
1 participant
Summary
This PR improves Blitztext Linux compatibility diagnostics for different Linux desktop/session environments without expanding official support promises.
Changes:
scripts/verify.shxclipwl-copyydotoolas a warning instead of a hard failure, because transcription and clipboard-only mode still workdocs/setup.mdVerification
python3 -m compileall app testsQT_QPA_PLATFORM=offscreen WHISPER_GUI_TESTS=1 python -m pytest -qgit diff --checkbash -n scripts/verify.shbash -n scripts/install.shshellcheck scripts/verify.sh scripts/install.shResult before push:
447 passedROADMAP.mdnot trackedScope
This is diagnostics/documentation/test hardening only.
Not changed:
Support note
The compatibility matrix is diagnostic, not a support guarantee. Mint and Lubuntu are documented as untested VM targets for follow-up validation.
Merge note
Do not merge before CI is green and final approval is given.