-
Notifications
You must be signed in to change notification settings - Fork 177
docs: add migration guide for shadow variables (VariableListeners). #2053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
triceo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the surface!
I'm tagging in @Christopher-Chianelli for an in-depth review.
Christopher-Chianelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good, but I would make some changes to avoid potential confusion.
...pgrading-timefold-solver/migration-guides/variable-listeners-to-custom-shadow-variables.adoc
Outdated
Show resolved
Hide resolved
...pgrading-timefold-solver/migration-guides/variable-listeners-to-custom-shadow-variables.adoc
Outdated
Show resolved
Hide resolved
…n-guides/variable-listeners-to-custom-shadow-variables.adoc Co-authored-by: Christopher Chianelli <christopher@timefold.ai>
|



Solves part of #2043
This introduces a migration guide for migrating Variable Listeners to Custom Shadow Variables (declarative).
A 2nd PR later this iteration will tackle the "Chained" to "PlanningListVariable" migration.
Request: As I have less experience with VariableListeners, please check the syntax for those examples.