fix: fail fast if a range starts after it ends #2055
Conversation
Christopher-Chianelli
temporarily deployed
to
internal
GitHub Actions
Inactive
|
| this.value = value; | ||
| var start = startMapping.apply(value); | ||
| var end = endMapping.apply(value); | ||
| if (start.compareTo(end) > 0) { |
There was a problem hiding this comment.
This is a performance regression in a place where we likely can't afford one, especially if it's only to throw a different exception than would have been thrown anyway.
Is there perhaps a way to throw this exception in a place where we already have to do this comparison? Otherwise I'm considering just not fixing this; IMO this exception brings little additional value over the other exception.
There was a problem hiding this comment.
Not really (as we don't compare start and end value); TreeMap.subMap will throw the exception when it is eventually reached.
|
It was agreed that we would not fix this. |
2 participants
Fixes #2054