Convert to function component with hooks#8
Open
gmaclennan wants to merge 4 commits intoTitanInvest:masterfrom
Open
Convert to function component with hooks#8gmaclennan wants to merge 4 commits intoTitanInvest:masterfrom
gmaclennan wants to merge 4 commits intoTitanInvest:masterfrom
Conversation
No need to compile code when used with react native
Removes deprecated componentWillReceiveProps
|
Would be nice if this could be updated @zivester |
|
Any chance this could get merged, @zivester? 🙏 |
|
@zivester Would it be possible to merge this please? |
|
Thanks for the conversion to a function component, Im sorry we didnt notice this for months. This package is a bit tricky and is used in a few of our other apps, will test the new build process and update later this week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I updated this to use a function component, mainly for my own use, but leaving this here in case you want to want to update this library. This removes the deprecated
componentWillReceiveProps. It depends on hooks, so will only work withreact-native@^0.59.0. Also removes babel and compile step, since it's not needed for react-native use.