Fix skein scrolling to top on every edit (#45)#52
Open
angstsmurf wants to merge 1 commit into
Open
Conversation
Remove the first resizeView call in layoutSkeinWithAnimation:. It shrank the view before the report layout was accounted for, forcing the scroll view to jump to the top; the second resizeView call already sizes the view correctly. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45.
-layoutSkeinWithAnimation:inIFSkeinView.mcalledresizeViewtwice. The first call ran before the report layout was accounted for, temporarily shrinking the view and forcing the enclosing scroll view to jump to the top on every edit. The secondresizeViewcall (afterupdateLayoutWithReportDetails:) already sizes the view to the final layout, so the first call is redundant as well as harmful.This removes the first call, preserving the scroll position when editing the skein.
🤖 Generated with Claude Code