Skip to content

Fix canSpawnFor to use allMatch insted of anyMatch #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tofaa2 merged 2 commits into from
Mar 29, 2026
Merged

Fix canSpawnFor to use allMatch insted of anyMatch #50

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb2de0f
fix
Dominilk01 Mar 29, 2026
9b192e7
allMatch is weird on empty list
Dominilk01 Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/src/main/java/me/tofaa/entitylib/ve/ViewerEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,8 +121,8 @@ public void clearTracked() {
* @return true if the user passed and did not fail any rules, false otherwise
*/
public boolean canSpawnFor(User user, WrapperEntity entity) {
if (entity.getViewerRules().stream().anyMatch(rule -> rule.shouldSee(user))) return true;
return globalRules.stream().anyMatch(rule -> rule.shouldSee(user));
if (!entity.getViewerRules().isEmpty() && entity.getViewerRules().stream().allMatch(rule -> rule.shouldSee(user))) return true;
return globalRules.stream().allMatch(rule -> rule.shouldSee(user));
}

/**
Expand Down