Open
Conversation
jezztify
commented
Feb 7, 2026
- Added option in Settings > General
- Allow decompilation of lub files instead of the binary files when extracting them
- Added option in Settings > General - Allow decompilation of lub files instead of the binary files when extracting them
There was a problem hiding this comment.
Pull request overview
Adds a new extraction-time option to decompile compiled .lub (Lua bytecode) files into text when extracting from a GRF, wiring it through configuration, startup settings, and the Settings UI.
Changes:
- Add a new config-backed setting (
DecompileLubOnExtract) exposed in Settings > General. - Load/apply the setting at startup into
GRF.GrfSystem.Settings. - Update extraction thread logic to detect Lua bytecode and decompile
.lubcontent to text during extraction.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| GRFEditor/WPF/SettingsDialog.xaml.cs | Adds UI toggle for “Decompile LUB on extraction”. |
| GRFEditor/EditorMainWindow.xaml.cs | Loads the new config setting into Settings.DecompileLubOnExtract at startup. |
| GRFEditor/ApplicationConfiguration/GrfEditorConfiguration.cs | Persists the new setting via ConfigAsker and syncs it into Settings. |
| GRFEditor.sln | Adds a GRF.Tests project reference/config entries. |
| GRF/Threading/GrfThreadExtract.cs | Implements Lua bytecode detection and conditional .lub decompilation during extraction. |
| GRF/GrfSystem/Settings.cs | Adds DecompileLubOnExtract setting to GRF runtime settings. |
| GRF/AssemblyInfo.cs | Exposes internals to GRF.Tests via InternalsVisibleTo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…by reading source bytes, detecting bytecode, and writing the decompiled output. - Included error handling consistent with the main extraction branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.