Update networkx dependency version to 3.4.2#1
Conversation
The current constraints cannot be satisfied for Python 3.10 because networkx>=3.5 requires Python 3.11. If you allow for networkx>=3.4.2, then Python 3.10 can be used too.
|
oh wait, i remember it is the |
|
and 3.11 for that matter |
|
It is a shame that the type hinting I used requires such recent versions. Especially since it doesn't do anything at runtime. I'm thinking I'd be happy to relax the |
There was a problem hiding this comment.
Pull request overview
This pull request reduces the minimum required version of the networkx dependency from 3.5 to 3.4.2 to enable Python 3.10 compatibility. NetworkX 3.5+ requires Python 3.11, which conflicts with the project's stated requirement of Python >=3.10.
Changes:
- Updated networkx minimum version constraint from >=3.5 to >=3.4.2 in dependencies
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Fixed by also relaxing |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
I think after copilot's suggestion to keep |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
The current constraints cannot be satisfied for Python 3.10 because networkx>=3.5 requires Python 3.11.
If you allow for networkx>=3.4.2, then Python 3.10 can be used too.
Ignore or close as you wish!