Property System: PUNA_BOSS#1245
Open
Stranger1992 wants to merge 13 commits into
Open
Conversation
* Lightning Attack Damage * Attacks Before Lizard Summon * Alert Range (blocks) * Turn Rate * Lightning Color
Stranger1992
added
the
property system
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends Tomb Editor’s TEN property catalog system by introducing a new property catalog for the PUNA_BOSS moveable, exposing configurable combat/behavior parameters plus visual and sound-related settings via the property grid.
Changes:
- Added a new TEN property catalog file defining PUNA_BOSS properties (damage, attack cadence, alert range, turn rate, colors, sounds).
- Updated
TombLib.csprojto copy the new catalog into the output. - Updated installer changelog to mention the new customizable PUNA_BOSS properties.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| TombLib/TombLib/TombLib.csproj | Adds an output-copy rule for the new TEN property catalog file (currently points at the wrong filename). |
| TombLib/TombLib/Catalogs/TEN Property Catalogs/TR3/ID_PUNA_BOSS.xml | New property catalog exposing PUNA_BOSS tuning parameters, colors, and sound IDs. |
| Installer/Changes.txt | Notes the addition of PUNA_BOSS TEN property system customization in release notes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+429
to
+434
| <None Update="Catalogs\TEN Property Catalogs\TR3\ID_PUNA.xml"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> | ||
| <None Update="Catalogs\TEN Property Catalogs\TR3\ID_PUNA_BOSS.xml"> | ||
| <CopyToOutputDirectory>Always</CopyToOutputDirectory> | ||
| </None> |
Comment on lines
+88
to
+95
| <property | ||
| internalName="PunaHitSound" | ||
| displayName="Hit sound" | ||
| type="Int" | ||
| defaultValue="695" | ||
| category="Sounds" | ||
| description="Sound played when Puna is hit." | ||
| /> |
Comment on lines
+96
to
+103
| <property | ||
| internalName="PunaDeathSound" | ||
| displayName="Death sound" | ||
| type="Int" | ||
| defaultValue="693" | ||
| category="Sounds" | ||
| description="Sound played when Puna is dying." | ||
| /> |
Comment on lines
+104
to
+111
| <property | ||
| internalName="PunaChairTurnSound" | ||
| displayName="Chair turning sound" | ||
| type="Int" | ||
| defaultValue="696" | ||
| category="Sounds" | ||
| description="Sound played when Puna's chair is turning." | ||
| /> |
Comment on lines
+112
to
+119
| <property | ||
| internalName="PunaChairTurnEndSound" | ||
| displayName="Chair turning end sound" | ||
| type="Int" | ||
| defaultValue="692" | ||
| category="Sounds" | ||
| description="Sound played when Puna's chair has finished turning." | ||
| /> |
Comment on lines
+22
to
+23
| TEN property system updates: | ||
| * Added properties for customising PUNA_BOSS lightning colours, hardcoded sounds, attack damage and behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces new customizable properties for the PUNA_BOSS enemy in the Tomb Engine (TEN) property system, allowing for greater control over its behavior, visuals, and sounds. These changes make it easier to tweak the boss's lightning attacks, summoning behavior, and associated effects directly through property definitions.
TEN property system enhancements:
ID_PUNA_BOSS.xml) defining customizable properties for PUNA_BOSS, including attack damage, attack count, alert range, turn rate, lightning and effect colors, and sound assignments.TombLib.csproj) to ensure the new property catalog for PUNA_BOSS is copied to the output directory.Documentation:
Installer/Changes.txtto note the addition of customizable PUNA_BOSS properties for lightning colors, sounds, attack damage, and behavior.