Open
Conversation
Member
Author
|
Hi @casperdcl do you think we'd have to patch the metadata of existing cvxpy releases to get this working, as suggested in this comment? |
Member
|
oddly, our CI seems to be picking up |
Member
|
ah of course, it'll see I suppose we need to have |
Member
Author
|
Ok, I'll update to: cvxpy!=1.8.2 |
lauramurgatroyd
commented
Apr 15, 2026
Co-authored-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com> Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
Member
Author
|
It should be fine but I tried to run all tests but can't due to this issue: #2308 (comment) https://github.com/TomographicImaging/CIL/actions/runs/24447602072 |
casperdcl
requested changes
Apr 15, 2026
Co-authored-by: Casper da Costa-Luis <imaging@cdcl.ml> Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
casperdcl
approved these changes
Apr 17, 2026
Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Now that conda-forge/cvxpy-feedstock#125 has been merged, the new cvxpy versions which only work with numpy 2 and above, should have the appropriate requirement of numpy version, so we shouldn't have to pin the cvxpy version.
However, as a release of cvxpy = 1.8.2 exists without the correct numpy pin, we can't use that version.
We will need a separate PR to address https://github.com/TomographicImaging/CIL/ , after we support numpy2 : #2305
Example Usage
Contribution Notes
Changes
Testing you performed
Trying to run all tests at: https://github.com/TomographicImaging/CIL/actions/runs/24447602072
Related issues/links
Checklist