Remove code which has been deprecated since v24.3 or earlier#2309
Draft
lauramurgatroyd wants to merge 6 commits intomasterfrom
Draft
Remove code which has been deprecated since v24.3 or earlier#2309lauramurgatroyd wants to merge 6 commits intomasterfrom
lauramurgatroyd wants to merge 6 commits intomasterfrom
Conversation
lauramurgatroyd
commented
Apr 15, 2026
| warn("use `run(callbacks=[LogfileCallback(log_file)])` instead of `log_file`", | ||
| DeprecationWarning, stacklevel=2) | ||
| self.__log_file = log_file | ||
| self.max_iteration = 1 |
Member
Author
There was a problem hiding this comment.
TODO: check if this is handled ok, without it the ProgressCallback threw an error
Need to test real life behaviour of ProgressCallback
Member
Author
|
Current failures:
|
lauramurgatroyd
commented
Apr 17, 2026
Comment on lines
183
to
192
| def max_iteration(self): | ||
| '''gets the maximum number of iterations''' | ||
| return self.__max_iteration | ||
|
|
||
| @max_iteration.setter | ||
| def max_iteration(self, value): | ||
| '''sets the maximum number of iterations''' | ||
| assert isinstance(value, Integral) or np.isposinf(value) | ||
| self.__max_iteration = value | ||
|
|
Member
Author
There was a problem hiding this comment.
should this property be removed? It hasn't been deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #2042
Example Usage
Contribution Notes
❤️ Thanks for your contribution!