Conversation
update dxchange min version fix zenodo_get line
casperdcl
force-pushed
the
main
branch
4 times, most recently
from
6069090 to
f7e963c
Compare
|
Hi Edo, this looks sensible. For linux would it still be recommended to use the create_local_env_for_cil_development.sh script or do you suggest removing that? The script which also includes libgcc-ng libstdcxx-ng for linux. |
| @@ -0,0 +1,36 @@ | |||
| name: cil_test | |||
There was a problem hiding this comment.
Should this be called cil_dev if it's replacing the instructions for creating a dev environment?
There was a problem hiding this comment.
no strong opinion, but probably yes
lauramurgatroyd
left a comment
lauramurgatroyd
left a comment
There was a problem hiding this comment.
@gfardell and I discussed the purpose of the scripts repository: https://github.com/TomographicImaging/scripts/
The scripts repository was originally created to store environment files which include a pinned version of CIL - like for installing the CIL-Demos.
We do not think these environment files for development should live in scripts, they should instead live in CIL, as these environment files need to always be updated along with CIL, e.g. in this PR which just went into CIL, the environment files had to be touched: TomographicImaging/CIL#2287. It would be too much overhead to make sure the separate scripts repo is kept aligned.
Additionally, to be able to build CIL they need to have the CIL repository cloned anyway so the dev environment file may as well be in CIL. Whereas for CIL-Demos they don't need CIL cloned, and we only update the environment file for CIL-Demos when we release a version that supports a later version of CIL.
3 participants
Create development enviroment and update Info on CIL's readme for local development.