fix: handle declaration merging and function overloads correctly#13
Merged
fix: handle declaration merging and function overloads correctly#13
Conversation
- Group symbols by name+kind before comparing old vs new file versions. A symbol is deleted only when ALL declarations are removed, not when one of several merged declarations disappears. - Deduplicate deleted symbols for fully removed files (2 interface User declarations → 1 deletion, not 2). - Compare signature sets across groups: if the set of signatures changed, flag as modified. Prevents false modification flags from comparing individual declarations against a single map entry. - Function overload signatures (without body) are not extracted by tree-sitter — only the implementation function is tracked. Removing an overload signature while keeping the implementation is correctly invisible to the tool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
interface User { name }+interface User { age }— removing one declaration now correctly flags as modified (not deleted), sinceUserstill exists via the other declaration.Test plan