split run configuration to Runmode and Base, add buffering and compression to monitoring and logging#47
Merged
brichards64 merged 10 commits intoToolDAQ:mainfrom Mar 19, 2026
Conversation
change logging severity type from unsigned int to LogLevel enum class change alarm level (int) to critical (bool) add buffering; only send first monitoring message each buffer period, stack logging duplicates within buffer period when identical messages are received back-to-back change config related methods to reflect restructuring: replace SendRunConfig with SendBaseConfig, SendRunModeConfig, GetRunConfig and GetRunDeviceConfig require base and runmode config ids. add zstd compression to messages in ServicesBackend, for now both multicast and zmq.
marc1uk
changed the title
… to Services class
brichards64
reviewed
Mar 19, 2026
src/ToolDAQChain/ToolDAQChain.cpp
Outdated
| @@ -177,7 +177,13 @@ void ToolDAQChain::Init(unsigned int IO_Threads){ | |||
Contributor
There was a problem hiding this comment.
please comment these out
comment out unused placeholders
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.