[revert,refactor]: revert various breaking changes to finalize v0 changes#32
Closed
null8626 wants to merge 8 commits intoTop-gg-Community:mainfrom
Closed
[revert,refactor]: revert various breaking changes to finalize v0 changes#32null8626 wants to merge 8 commits intoTop-gg-Community:mainfrom
null8626 wants to merge 8 commits intoTop-gg-Community:mainfrom
Conversation
d86ab44 to
60e3e22
Compare
4e40dfe to
30bf2bc
Compare
Closed
1fa9c57 to
30bf2bc
Compare
Member
Author
|
Closed in anticipation of a major update that adds v1 support but deletes all v0 features. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following pull request is a toned down version of #29 and a continuation of #30. This pull request focuses on the changes done to revert the various breaking changes done to the SDK since update v1.4.1 while also integrating it with newer updates done to v0 like bot reviews.
For a more comprehensive diff since commit
a7ed300, see a7ed300...null8626:rust-sdk:split/revert-v2.The most notable changelog of this pull request is that testing is now done in doctests, instead of a separate unit test file (
test.rs.)Other notable changelogs (since THAT commit):
src/autoposter/mod.rs:serenity-cachedcfg feature alongsideserenityin various parts.wait()feature, so the autoposter is now consistent in its posting without having to wait for newer server counts. This also helps with testing.Defaultimplementation.Derefusage.src/autoposter/serenity_impl.rs:pastedependency again.src/autoposter/twilight_impl.rs:DerefMutusage.src/bot.rs:topgg_id.discriminatorproperty during deserialization.guildsproperty during deserialization.banner_urlproperty during deserialization.approved_atin favor ofsubmitted_at.shardsproperty during deserialization.is_certifiedproperty during deserialization.avatarattribute public.vanityattribute public.server_countattribute public.avatargetter method.shard_countgetter method always return 0.sortsupport forget_bots.write!().src/client.rs:post_stats.pageargument toget_voters/bots/{id}/votes?page={page}instead of/bots/votes.get_user. Now it always fails. (Tried testing it, it always gives 404 now.)src/error.rs:InvalidRequesterror type.src/user:avatarattribute public.src/webhook/actix-web:src/webhook/axum:TCPListenerinstead of Rust'sSocketAddr.async-traitdependency directly.src/webhook/vote.rs:is_server.src/webhook/warp.rs:This branch is already tested and linted (via
cargo test,cargo c,cargo clippy, andcargo doc --no-deps.)