Bugfixes for: RestrictEvents, GiveGifft & ObjectsInRange#7
Merged
TorannD merged 9 commits intoTorannD:mainfrom Mar 29, 2026
Merged
Bugfixes for: RestrictEvents, GiveGifft & ObjectsInRange#7TorannD merged 9 commits intoTorannD:mainfrom
TorannD merged 9 commits intoTorannD:mainfrom
Conversation
Salvagers is faction without settlements that raids player in space, like Horax Cultists. So to make space non-peaceful place, we enable Salvagers raids. We probably should also enable mech raids. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Saw lot of people complaining about that, although it is good change imo. So revert it back, which often results in 0 caravans through whole gameplay. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
This change shouldn't be necessary but it seems that mech raids are blocked in some cases. Not sure why but this change does ensire they happen. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
There is an issue that 'GiveGift' Harmony patch does keep items after giving gift due to return value of 'false' which does not execute main function then. We fix it by returning true and executing original function. Also change behavior to always increase RimWar settlement points when giving gift, not only for allies. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
All current checks regarding sending parties count RimWarPoints, but do not account for PointDamage. That has two bad effects: - settlement can send parties having more points that (settlement - damange) - settlement can send parties when barely alive Address it in indirect way, by ensuring there is enough points to not break math (although it can leave settlement with only damaged points) and block sending parties when having less than half points (meaning half damaged) Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
It should not be generally checked, but we were observing an error of: 'Attempted to access a tile with ID 201789, but it is out of range (count: 2432)' This might be caused by scanning objects in space, but RimWorld debug view does not allow good way of identifying tile ID's (have to manually click all). Adding this checks costs us nothing and might be actual solution. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
There has been report of broken ComsConsole in space, which makes sense, since stuff like reinforcement doesn't really work in space. So disable these options while in space. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Currently if trader does arrive to player faction it loses half of the points, which is weakening the faction that trades with player. This seems to not be best design, so change it to be profitable to trade with player. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
Same as recent GiveGift, re-enable RimWar point increase from gifts for pods. Signed-off-by: Jakub Raczynski <myszsoda@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are still issues with Threading, but when Threading is disabled, this change does fix almost all currently present issues.
There is still issue with Caravan Path leak, but this can be ignored and would require lot of rewriting.