Skip to content

yaml 환경변수에 맞게 수정#36

Merged
minwoo-3 merged 1 commit into
developfrom
refator/mail-yaml
Jul 4, 2026
Merged

yaml 환경변수에 맞게 수정#36
minwoo-3 merged 1 commit into
developfrom
refator/mail-yaml

Conversation

@minwoo-3

@minwoo-3 minwoo-3 commented Jun 23, 2026

Copy link
Copy Markdown
Collaborator

📃 작업내용

  • yaml 환경변수에 맞게 수정했습니다

🙋‍♂️ 참고사항

✅ PR 체크리스트

템플릿 체크리스트 말고도 추가적으로 필요한 체크리스트는 추가해주세요!

  • 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. .env, 노션, README)
  • 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "환경값 추가되었어요")
  • 작업한 코드가 정상적으로 동작하나요?
  • Merge 대상 브랜치가 올바른가요?
  • PR과 관련 없는 작업이 있지는 않나요?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the Spring Mail configuration in application.yaml by removing the default empty string fallback from the MAIL_PASSWORD environment variable placeholder. The reviewer pointed out that this change could cause application startup failures in environments where the variable is not defined (such as local development) and recommended keeping the fallback to ensure the application can still run.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

port: 587
username: ${MAIL_USERNAME:whereg87@gmail.com}
password: ${MAIL_PASSWORD:}
password: ${MAIL_PASSWORD}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

${MAIL_PASSWORD} 환경 변수의 기본값 :을 제거하면, 로컬 개발 환경 등에서 해당 환경 변수가 설정되어 있지 않을 때 애플리케이션 기동 시 Could not resolve placeholder 예외가 발생하여 애플리케이션이 실행되지 않습니다. 이메일 발송 기능이 필수가 아닌 로컬 환경에서도 애플리케이션이 정상적으로 실행될 수 있도록 빈 문자열(:)이라도 기본값으로 제공하는 것을 권장합니다.

    password: ${MAIL_PASSWORD:}

@minwoo-3 minwoo-3 changed the base branch from master to develop July 4, 2026 13:05
@minwoo-3 minwoo-3 merged commit 0fd8e54 into develop Jul 4, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant