Skip to content

yaml환경변수 변경#37

Merged
minwoo-3 merged 2 commits into
masterfrom
develop
Jul 4, 2026
Merged

yaml환경변수 변경#37
minwoo-3 merged 2 commits into
masterfrom
develop

Conversation

@minwoo-3

@minwoo-3 minwoo-3 commented Jul 4, 2026

Copy link
Copy Markdown
Collaborator

📃 작업내용

🙋‍♂️ 참고사항

✅ PR 체크리스트

템플릿 체크리스트 말고도 추가적으로 필요한 체크리스트는 추가해주세요!

  • 이 작업으로 인해 변경이 필요한 문서가 변경되었나요? (e.g. .env, 노션, README)
  • 이 작업을 하고나서 공유해야할 팀원들에게 공유되었나요? (e.g. "API 개발 완료됐어요", "환경값 추가되었어요")
  • 작업한 코드가 정상적으로 동작하나요?
  • Merge 대상 브랜치가 올바른가요?
  • PR과 관련 없는 작업이 있지는 않나요?

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the default empty string fallback for the MAIL_PASSWORD environment variable in application.yaml. The reviewer correctly pointed out that this change can cause the application to fail to start in environments where the environment variable is not defined, and suggested keeping the default fallback value.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

port: 587
username: ${MAIL_USERNAME:whereg87@gmail.com}
password: ${MAIL_PASSWORD:}
password: ${MAIL_PASSWORD}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

${MAIL_PASSWORD}와 같이 기본값 없이 플레이스홀더를 정의하면, 로컬 개발 환경이나 빌드/테스트 환경 등에서 MAIL_PASSWORD 환경 변수가 설정되어 있지 않을 경우 애플리케이션 구동 시 IllegalArgumentException (Could not resolve placeholder) 에러가 발생하며 기동에 실패하게 됩니다.\n\n로컬 환경에서 메일 기능이 필수적이지 않더라도 애플리케이션이 정상적으로 실행될 수 있도록 기존처럼 빈 문자열이라도 기본값(:)을 지정해 두는 것을 권장합니다.

    password: ${MAIL_PASSWORD:}

@minwoo-3 minwoo-3 changed the title Develop yaml환경변수 변경 Jul 4, 2026
@minwoo-3 minwoo-3 merged commit e4115d2 into master Jul 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant