Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the default empty string fallback for the MAIL_PASSWORD environment variable in application.yaml. The reviewer correctly pointed out that this change can cause the application to fail to start in environments where the environment variable is not defined, and suggested keeping the default fallback value.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| port: 587 | ||
| username: ${MAIL_USERNAME:whereg87@gmail.com} | ||
| password: ${MAIL_PASSWORD:} | ||
| password: ${MAIL_PASSWORD} |
There was a problem hiding this comment.
${MAIL_PASSWORD}와 같이 기본값 없이 플레이스홀더를 정의하면, 로컬 개발 환경이나 빌드/테스트 환경 등에서 MAIL_PASSWORD 환경 변수가 설정되어 있지 않을 경우 애플리케이션 구동 시 IllegalArgumentException (Could not resolve placeholder) 에러가 발생하며 기동에 실패하게 됩니다.\n\n로컬 환경에서 메일 기능이 필수적이지 않더라도 애플리케이션이 정상적으로 실행될 수 있도록 기존처럼 빈 문자열이라도 기본값(:)을 지정해 두는 것을 권장합니다.
password: ${MAIL_PASSWORD:}
📃 작업내용
🙋♂️ 참고사항
✅ PR 체크리스트
.env,노션,README)"API 개발 완료됐어요","환경값 추가되었어요")