feat:FRO-6/stock search and ui change #9
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,3 +32,8 @@ dist-ssr | |
|
|
||
| # Test coverage | ||
| coverage | ||
|
|
||
| # Local Agent Skills | ||
| .agents/ | ||
| skills-lock.json | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,7 +1,19 @@ | ||||||
| import React from 'react'; | ||||||
| import { useNavigate, useLocation } from 'react-router-dom'; | ||||||
| import { | ||||||
| Zap, | ||||||
| Search, | ||||||
| LayoutGrid, | ||||||
| PieChart, | ||||||
| LineChart, | ||||||
| Bot, | ||||||
| Globe, | ||||||
| Settings, | ||||||
| LogOut, | ||||||
| } from 'lucide-react'; | ||||||
| import type { UserResponse } from '@/features/auth/auth.types'; | ||||||
| import { ROUTES } from '@/constants/routes.constants'; | ||||||
| import '@/styles/components/sidebar.css'; | ||||||
|
|
||||||
| interface SidebarProps { | ||||||
| user: UserResponse | null; | ||||||
|
|
@@ -12,243 +24,109 @@ export const Sidebar: React.FC<SidebarProps> = ({ user, onLogout }) => { | |||||
| const navigate = useNavigate(); | ||||||
| const location = useLocation(); | ||||||
|
|
||||||
| const isExploreActive = location.pathname === ROUTES.EXPLORE; | ||||||
| const isDashboardActive = location.pathname === ROUTES.DASHBOARD; | ||||||
|
|
||||||
| const username = user?.username || 'Anjal Dev VK'; | ||||||
|
There was a problem hiding this comment. 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win Hardcoded developer name as username fallback.
✏️ Proposed fix- const username = user?.username || 'Anjal Dev VK';
+ const username = user?.username || 'Guest';📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||
|
|
||||||
| return ( | ||||||
| <aside className="vercel-sidebar"> | ||||||
| {/* Scrollable Navigation Area */} | ||||||
| <div className="sidebar-scrollable-content"> | ||||||
| {/* Top Workspace Header Selector */} | ||||||
| <div className="sidebar-workspace-bar"> | ||||||
| <div className="sidebar-workspace-info"> | ||||||
| <div className="sidebar-workspace-avatar"> | ||||||
| <Zap size={12} strokeWidth={2.5} /> | ||||||
| </div> | ||||||
| <span className="sidebar-workspace-name">{username}</span> | ||||||
| </div> | ||||||
| <span className="sidebar-workspace-badge">Pro</span> | ||||||
| </div> | ||||||
|
|
||||||
| {/* Search Input Box */} | ||||||
| <div className="sidebar-search-box"> | ||||||
| <div className="sidebar-search-placeholder"> | ||||||
| <Search size={13} strokeWidth={2} /> | ||||||
| <span>Find</span> | ||||||
| </div> | ||||||
| <span className="sidebar-search-key">F</span> | ||||||
| </div> | ||||||
|
|
||||||
| {/* Sidebar Navigation */} | ||||||
| <div className="sidebar-nav-list"> | ||||||
| <button | ||||||
| className={`sidebar-nav-item ${isExploreActive ? 'active' : ''}`} | ||||||
| onClick={() => navigate(ROUTES.EXPLORE)} | ||||||
| > | ||||||
| <div className="sidebar-item-left"> | ||||||
| <span className="sidebar-item-icon"> | ||||||
| <LayoutGrid size={15} strokeWidth={2} /> | ||||||
| </span> | ||||||
| <span>Explore Markets</span> | ||||||
| </div> | ||||||
| </button> | ||||||
|
|
||||||
| <button | ||||||
| className={`sidebar-nav-item ${isDashboardActive ? 'active' : ''}`} | ||||||
| onClick={() => navigate(ROUTES.DASHBOARD)} | ||||||
| > | ||||||
| <div className="sidebar-item-left"> | ||||||
| <span className="sidebar-item-icon"> | ||||||
| <PieChart size={15} strokeWidth={2} /> | ||||||
| </span> | ||||||
| <span>Portfolio</span> | ||||||
| </div> | ||||||
| </button> | ||||||
|
|
||||||
| <button className="sidebar-nav-item"> | ||||||
| <div className="sidebar-item-left"> | ||||||
| <span className="sidebar-item-icon"> | ||||||
| <LineChart size={15} strokeWidth={2} /> | ||||||
| </span> | ||||||
| <span>Analytics</span> | ||||||
| </div> | ||||||
| </button> | ||||||
|
|
||||||
| <button className="sidebar-nav-item"> | ||||||
| <div className="sidebar-item-left"> | ||||||
| <span className="sidebar-item-icon"> | ||||||
| <Bot size={15} strokeWidth={2} /> | ||||||
| </span> | ||||||
| <span>AI Discipline</span> | ||||||
| </div> | ||||||
| <span className="sidebar-badge-beta">Beta</span> | ||||||
| </button> | ||||||
|
|
||||||
| <div className="sidebar-divider" /> | ||||||
|
|
||||||
| <button className="sidebar-nav-item"> | ||||||
| <div className="sidebar-item-left"> | ||||||
| <span className="sidebar-item-icon"> | ||||||
| <Globe size={15} strokeWidth={2} /> | ||||||
| </span> | ||||||
| <span>Global Feeds</span> | ||||||
| </div> | ||||||
| </button> | ||||||
|
|
||||||
| <button className="sidebar-nav-item"> | ||||||
| <div className="sidebar-item-left"> | ||||||
| <span className="sidebar-item-icon"> | ||||||
| <Settings size={15} strokeWidth={2} /> | ||||||
| </span> | ||||||
| <span>Settings</span> | ||||||
| </div> | ||||||
| </button> | ||||||
| </div> | ||||||
| </div> | ||||||
|
|
||||||
| {/* Pinned Logout Button at Bottom of Sidebar */} | ||||||
| <div className="sidebar-pinned-bottom"> | ||||||
| <button className="sidebar-logout-full-btn" onClick={onLogout}> | ||||||
| <LogOut size={14} strokeWidth={2} /> | ||||||
| <span>Log Out</span> | ||||||
| </button> | ||||||
| </div> | ||||||
| </aside> | ||||||
| ); | ||||||
| }; | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
Repository: TradeDisciplineAI/frontned
Length of output: 3145
🏁 Script executed:
Repository: TradeDisciplineAI/frontned
Length of output: 1192
Load
Interfor the theme’s base font.tokens.csssets--font-family-baseto start withInter, anddashboard.cssrelies on that variable. If the variable is absent, it falls back toPlus Jakarta Sans, which this stylesheet already loads but is not the configured base font. Add theInterGoogle Fonts stylesheet/preconnect so dashboard matches the rest of the UI; keep the existingPlus Jakarta Sanslink only if this fallback behavior is intentional.🤖 Prompt for AI Agents