Conversation
WalkthroughUpdated the Amoy network configuration to use the main Polygon gas station URL instead of the testnet endpoint. No other networks or logic were modified, and no public types or signatures changed. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
src/common/networks.ts (1)
5-5: Amoy gas token is POL, not MATICDocs list Amoy’s gas token as POL (chain id 80002). Keeping "MATIC" will mislabel fees/UX in the CLI. Recommend adding "POL" to the currency union and setting Amoy’s currency to "POL" here. (docs.polygon.technology)
Apply:
- export type networkCurrency = "ETH" | "MATIC" | "XDC" | "FREE" | "ASTRON"; + export type networkCurrency = "ETH" | "MATIC" | "POL" | "XDC" | "FREE" | "ASTRON";[NetworkCmdName.Amoy]: { explorer: "https://www.oklink.com/amoy", provider: jsonRpcProvider("https://polygon-amoy.infura.io/v3/48bea089ceb34f579d2381195ca46c1d"), networkId: 80002, networkName: NetworkCmdName.Amoy, - currency: "MATIC", + currency: "POL", gasStation: gasStation("https://gasstation.polygon.technology/amoy"), },Also applies to: 72-79
🧹 Nitpick comments (1)
src/common/networks.ts (1)
72-74: Optional: use PolygonScan for explorerOfficial docs point to PolygonScan for Amoy. Consider switching the explorer URL. (docs.polygon.technology)
- explorer: "https://www.oklink.com/amoy", + explorer: "https://amoy.polygonscan.com",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/common/networks.ts(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
src/common/networks.ts (1)
src/common/gas-station/index.ts (1)
gasStation(7-20)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Tests / Run Tests
🔇 Additional comments (1)
src/common/networks.ts (1)
72-79: Correct Amoy gas station endpointSwitching Amoy to
https://gasstation.polygon.technology/amoymatches Polygon’s official docs and the JSON schema expected bygasStation()(standard.maxPriorityFee/maxFee in gwei). Looks good. (docs.polygon.technology)
|
🎉 This PR is included in version 3.2.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Summary
amoy gas station url update.
Summary by CodeRabbit