Skip to content

chore: update node version#84

Open
RishabhS7 wants to merge 4 commits intomasterfrom
chore/update-node-version
Open

chore: update node version#84
RishabhS7 wants to merge 4 commits intomasterfrom
chore/update-node-version

Conversation

@RishabhS7
Copy link
Copy Markdown
Contributor

@RishabhS7 RishabhS7 commented Mar 25, 2026

Summary

Updated node version to 22

Summary by CodeRabbit

  • Chores
    • Upgraded Node.js runtime from 20 to 22 across CI workflows and local runtime config (.nvmrc).
    • Updated package.json to require Node 22 and bumped TypeScript Node type definitions to match Node 22.
    • CI steps (dependency install, code style checks, lint and test runs) now execute using Node 22; change applied to both main and forked workflow configs.

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 25, 2026

Deploy Preview for tradetrust-functions ready!

Name Link
🔨 Latest commit 9f7ee13
🔍 Latest deploy log https://app.netlify.com/projects/tradetrust-functions/deploys/69c3caa821d91a000832b0d2
😎 Deploy Preview https://deploy-preview-84--tradetrust-functions.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 63ad76bf-1df5-4053-af01-ccc0e020ad84

📥 Commits

Reviewing files that changed from the base of the PR and between 002545e and 9f7ee13.

📒 Files selected for processing (1)
  • package.json
✅ Files skipped from review due to trivial changes (1)
  • package.json

📝 Walkthrough

Walkthrough

Bumped Node.js references from 20 to 22 across CI workflows, local config, and package metadata; updated @types/node to ^22.19.15 and engines.node to >=22.x in package.json.

Changes

Cohort / File(s) Summary
GitHub Actions Workflows
\.github/workflows/manual.yml, \.github/workflows/manual_forked.yml
Changed actions/setup-node@v4 node-version from 20.x22.x; CI steps (npm ci, Snyk, Prettier, lint, tests) now run on Node 22.
Local & Package Configuration
\.nvmrc, package.json
Updated .nvmrc value 2022; in package.json bumped @types/node ^18.8.5^22.19.15 and engines.node >=20.x>=22.x.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I hopped through lines and chewed a clue,
Swapped twenty for twenty-two — fresh dew!
Workflows wake and tests rehearse,
Tiny change, a hopeful verse,
Nibbles done, I twitch anew. 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is incomplete; it only provides a brief summary but is missing the 'Changes' and 'Issues' sections required by the repository template. Add a 'Changes' section listing the specific files modified (workflows, .nvmrc, package.json, @types/node) and an 'Issues' section referencing any related issues or stories.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: update node version' accurately describes the main change - updating Node.js from version 20 to 22 across all configuration files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/update-node-version

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@package.json`:
- Around line 65-67: The packageManager field currently declares "yarn@4.9.2..."
but the repo uses npm (package-lock.json and CI runs `npm ci`), creating a
mismatch; either remove the "packageManager" field from package.json to reflect
npm as the package manager, or update repository workflows and tooling to use
Yarn (replace `npm ci` with `yarn install` in CI, add a yarn.lock, and ensure
Corepack/Yarn is enabled), and keep the packageManager entry in package.json
only if you switch all workflows to Yarn.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 42010a69-e2d4-4ee4-98d6-9d52da4539a2

📥 Commits

Reviewing files that changed from the base of the PR and between c9df080 and 241c260.

⛔ Files ignored due to path filters (2)
  • package-lock.json is excluded by !**/package-lock.json
  • test-output.log is excluded by !**/*.log
📒 Files selected for processing (4)
  • .github/workflows/manual.yml
  • .github/workflows/manual_forked.yml
  • .nvmrc
  • package.json

@RishabhS7 RishabhS7 requested a review from manishdex25 March 25, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants