Data: Add Google Translate Support Indicator#689
Conversation
Cloudflare Pages preview
|
conradarcturus
left a comment
There was a problem hiding this comment.
Minor changes, nonetheless this looks great :)
Also, we should add this to LanguageDetailsVitalityAndViability
but you can do these now or go back to it later.
| const GoogleTranslateSupportStatus: React.FC<{ lang: LanguageData }> = ({ lang }) => { | ||
| if (!lang.googleTranslate || lang.googleTranslate.length === 0) { | ||
| return ( | ||
| <XCircleIcon style={{ color: 'var(--color-red)', verticalAlign: 'middle' }} size={'1em'} /> |
There was a problem hiding this comment.
There seems to be some layout differences between this and the one below -- that's because the one below is part of a inline-flex component, this is not.
However I wouldn't worry about this, I filed #690 to make a hoverable icon component (or something) to standardize this better.
| zho Chinese (Simplified) | ||
| zho Chinese (Traditional) |
There was a problem hiding this comment.
mark it as zho/cmn for both
| kmr Kurdish (Kurmanji) | ||
| ckb Kurdish (Sorani) | ||
| kir Kyrgyz |
There was a problem hiding this comment.
Use https://translation-commons.github.io/lang-nav/data?objectType=Census&view=Reports&reportID=2 to mark macrolanguages. For example this these two are kur/kmr and kur/ckb
Part of #538
Summary: Add Google Translate support data to language records as part of the digital support indicators
Changes
public/data/google/gtranslate.tsv.Out of scope/Future work: Possible connection with Locales and Writing Systems.
Test Plan
How to test the changes in this PR: Run the app, open a language table view, and select the Google Translate option in the list of available digital support indicators. The status appears in the table with the expected hover text.
Checklist
Summary
Testing
npm run lintnpm run buildnpm run testnpm run dev-- tried out the website directlyChanges
Visual changes
Data changes
public/data/src/features/data/including how we aggregate data or compute derived valuesInternal changes
Docs