This repository was archived by the owner on Feb 1, 2026. It is now read-only.
fix(Line2): allow points to be added/removed, fix defineExpose ref#523
Closed
andretchen0 wants to merge 4 commits intomainfrom
Closed
fix(Line2): allow points to be added/removed, fix defineExpose ref#523andretchen0 wants to merge 4 commits intomainfrom
andretchen0 wants to merge 4 commits intomainfrom
Conversation
❌ Deploy Preview for cientos-tresjs failed. Why did it fail? →
|
commit: |
Merged
Contributor
Author
|
Mysterious Netlify errors here. Seemingly unrelated to the PR, according to the Netlify build logs. Closing and resubmitting a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After initial creation, additional points could not be added to Cientos' Line2 component. The on-screen component would not display the additional points.
Solution
Recreate the Line2 geometry to accommodate the additional points.
Problem
The
defineExposedinstanceisundefinedbecause here ......
:refshould beref.Solution
Remove the colon from
:ref.Meta
Closes Tresjs/tres#1142