Skip to content

joyent/node-manta#290 Switch muntar over to use tar-stream#367

Open
joyent-automation wants to merge 1 commit into
masterfrom
cr1037-joyent-node-manta-290
Open

joyent/node-manta#290 Switch muntar over to use tar-stream#367
joyent-automation wants to merge 1 commit into
masterfrom
cr1037-joyent-node-manta-290

Conversation

@joyent-automation

Copy link
Copy Markdown

#290 Switch muntar over to use tar-stream

This PR was migrated-from-gerrit, https://cr.joyent.us/#/c/1037/.
The raw archive of this CR is here.
See MANTA-4594 for info on Joyent Eng's migration from Gerrit.

CR discussion

@trentm commented at 2016-12-02T23:17:46

Patch Set 1: Code-Review+1

Gah. I spent time scratching my head how dirs are handled by muntar then realized there is already #259 for that (hint hint, if you want jperkin). :)

Code looks good to me and works with the couple tars I tried.

How do we decide we are comfortable enough to release this? tar-stream has some tests at least.

@trentm trentm removed their request for review October 21, 2019 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants