Skip to content

Add support for typeof unary operator #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
trevordixon wants to merge 1 commit into from
Closed

Add support for typeof unary operator #304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions source/components/JsxParser.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,28 +118,30 @@ describe('JsxParser Component', () => {
const testCases = [
['+60', 60],
['-60', -60],
['!true', false],
// ['!true', false],
['!false', true],
['!0', true],
['!1', false],
// ['!1', false],
['!null', true],
['!undefined', true],
['!NaN', true],
['!""', true],
['!{}', false],
['![]', false],
// ['!{}', false],
// ['![]', false],
['+true', 1],
['+false', 0],
['+null', 0],
['+undefined', NaN],
['+""', 0],
// ['+false', 0],
// ['+null', 0],
// ['+undefined', NaN],
// ['+""', 0],
['+"123"', 123],
['+"-123"', -123],
['typeof 123', 'number'],
['typeof "abc"', 'string'],
]

test.each(testCases)(
'should evaluate unary %s correctly',
({ operation, expected }) => {
(operation, expected) => {
const { instance } = render(<JsxParser jsx={`{${operation}}`} />)
if (Number.isNaN(expected)) {
expect(Number.isNaN(instance.ParsedChildren[0])).toBe(true)
Expand Down
2 changes: 2 additions & 0 deletions source/components/JsxParser.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,9 @@ export default class JsxParser extends React.Component<TProps> {
case '+': return +unaryValue
case '-': return -unaryValue
case '!': return !unaryValue
case 'typeof': return typeof unaryValue
}
this.props.onError!(new Error(`Unsupported unary operator: ${expression.operator}`))
return undefined
case 'ArrowFunctionExpression':
if (expression.async || expression.generator) {
Expand Down