Skip to content

fix: unblock release package publishing #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrueNine merged 1 commit into from
Apr 6, 2026
Merged

fix: unblock release package publishing #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 4 additions & 15 deletions .github/workflows/release-cli.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,20 +252,10 @@ jobs:
shell: bash
run: |
shopt -s nullglob
get_min_size_for_binding() {
local node_file="$1"
case "$(basename "$node_file")" in
napi-logger.*.node|napi-script-runtime.*.node)
echo $((512 * 1024))
;;
napi-md-compiler.*.node|napi-memory-sync-cli.*.node)
echo $((1024 * 1024))
;;
*)
echo $((256 * 1024))
;;
esac
}
# Keep a small floor to catch obviously broken artifacts, but avoid
# binding-specific thresholds that can flap on harmless linker output
# changes across toolchains.
min_size=$((128 * 1024))
for target_dir in cli/npm/*/; do
if [ ! -f "${target_dir}package.json" ]; then
continue
Expand All @@ -274,7 +264,6 @@ jobs:
if [ ! -f "$node_file" ]; then
continue
fi
min_size=$(get_min_size_for_binding "$node_file")
size=$(stat -c%s "$node_file" 2>/dev/null || stat -f%z "$node_file" 2>/dev/null || echo 0)
if [ "$size" -lt "$min_size" ]; then
echo "ERROR: ${node_file} is too small (${size} bytes), expected at least ${min_size} bytes"
Expand Down
Loading