Skip to content

Fix WSL mirror sync lint regression #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TrueNine merged 1 commit into from
Mar 23, 2026
Merged

Fix WSL mirror sync lint regression #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions cli/src/wsl-mirror-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@ import type {
PluginOptions,
WslMirrorFileDeclaration
} from './plugins/plugin-core'
import {Buffer} from 'node:buffer'
import type {RuntimeEnvironmentContext} from './runtime-environment'
import {Buffer} from 'node:buffer'
import {spawnSync} from 'node:child_process'
import * as fs from 'node:fs'
import * as path from 'node:path'
Expand Down Expand Up @@ -137,8 +137,8 @@ function decodeWslCliOutput(
if (typeof value === 'string') return value
if (!Buffer.isBuffer(value) || value.length === 0) return ''

const hasUtf16LeBom = value.length >= 2 && value[0] === 0xff && value[1] === 0xfe
const hasUtf16BeBom = value.length >= 2 && value[0] === 0xfe && value[1] === 0xff
const hasUtf16LeBom = value.length >= 2 && value[0] === 0xFF && value[1] === 0xFE
const hasUtf16BeBom = value.length >= 2 && value[0] === 0xFE && value[1] === 0xFF
if (hasUtf16LeBom || hasUtf16BeBom) return value.toString('utf16le').replace(/^\uFEFF/u, '')

const utf8Text = value.toString('utf8')
Expand Down Expand Up @@ -308,7 +308,7 @@ function resolveGeneratedWslMirrorSource(

// Mirror home-style tool config roots only. Windows app-data trees such as
// AppData\Local\JetBrains\... stay Windows-only even though they live under the user profile.
if (topLevelSegment == null || !topLevelSegment.startsWith('.')) return void 0
if (!topLevelSegment?.startsWith('.')) return void 0

return {
kind: 'generated',
Expand Down Expand Up @@ -614,9 +614,10 @@ export async function syncWindowsConfigIntoWsl(
continue
}

const {relativePathSegments, sourcePath} = declaration

for (const resolvedTarget of resolvedTargets) {
const sourcePath = declaration.sourcePath
const targetPath = path.win32.join(resolvedTarget.windowsHomeDir, ...declaration.relativePathSegments)
const targetPath = path.win32.join(resolvedTarget.windowsHomeDir, ...relativePathSegments)

try {
if (ctx.dryRun === true) {
Expand Down
Loading