Draft
Conversation
Try
reviewed
Jan 28, 2026
Owner
Try
left a comment
Try
left a comment
There was a problem hiding this comment.
Hi, @psjuan97 and thanks for PR!
It doesn't look as bad as was was expecting from android, however how do you handle AndroidManifest.xml / gradle / .java ? I'm pretty sure, that you shown manifest on discord discussion, but I don't see it in PR.
| // On Android, we may need to swap width/height for projection matrix due to Vulkan transform issues | ||
| uint32_t projW = w, projH = h; | ||
|
|
||
| #if defined(__ANDROID__) |
Owner
There was a problem hiding this comment.
Sorry, but hacks in camera code for specific OS is not acceptable - just use auto-rotation.
| } | ||
|
|
||
| #if defined(__ANDROID__) | ||
| extern "C" void android_main(struct android_app* app) { |
Owner
There was a problem hiding this comment.
Need to move into Tempest, as it's an implementation detail.
| if(path == nullptr) | ||
| return u""; | ||
|
|
||
| // Convert UTF-8 to UTF-16 |
Author
|
I have it in a separated project, when i know a good way to included i will push it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.