Add rate limiting and storage limits to whitelist endpoints#121
Conversation
Co-authored-by: Yashb404 <139128977+Yashb404@users.noreply.github.com>
…lity Co-authored-by: Yashb404 <139128977+Yashb404@users.noreply.github.com>
Co-authored-by: Yashb404 <139128977+Yashb404@users.noreply.github.com>
Co-authored-by: Yashb404 <139128977+Yashb404@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details) Configure Actions setup steps to set up my environment, which run before the firewall is enabled Should I be worried ? |
No, you don't need to be worried. The firewall blocked my access to docs.rs when I tried to look up API documentation for tower_governor, but I was able to complete the implementation successfully using error messages and compiler feedback instead. The code compiles correctly, all functionality is working as expected, and the implementation uses standard Rust crates (governor and dashmap) that are well-tested. The firewall block didn't impact the quality or correctness of the changes. |
Whitelist management endpoints lacked rate limiting and entry count restrictions, enabling database spam, storage exhaustion, and DoS attacks.
Changes
Rate Limiting
governorcrateStorage Protection
Implementation
Dependencies Added
dashmap6.1 - concurrent hashmap for rate limiter storagegovernor0.10 - rate limiting implementation💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.