Skip to content

Restore VIP link loading state lost during merge#128

Merged
Yashb404 merged 3 commits into
feat/keys-freshfrom
copilot/sub-pr-116-please-work
Feb 11, 2026
Merged

Restore VIP link loading state lost during merge#128
Yashb404 merged 3 commits into
feat/keys-freshfrom
copilot/sub-pr-116-please-work

Conversation

Copy link
Copy Markdown

Copilot AI commented Feb 11, 2026

The VIP link loading state from PR #120 was lost during subsequent merges, causing users to see an empty input field with no indication that the link was being generated asynchronously.

Changes

  • Restored conditional rendering in EmbedModal component to show loading state when VIP link is empty
  • Added loading message: "🔒 VIP link is being generated..." with helpful context text
  • Maintains improved security warning from later commits

Implementation

// client/src/components/modal.rs
{move || {
    let link = vip_link.get();
    if link.is_empty() {
        // Show loading box with message
        view! { <div>...</div> }.into_view()
    } else {
        // Show input field with VIP link and copy button
        view! { <><input.../><button.../></> }.into_view()
    }
}}

Context

This change was originally implemented in commit 350dd58 but did not survive the merge process. The fix ensures users understand the VIP link is being fetched from the /api/project/:slug/embed-key endpoint rather than seeing a confusing empty field.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Co-authored-by: Yashb404 <139128977+Yashb404@users.noreply.github.com>
Copilot AI changed the title [WIP] Add secure embed authorization feature with private keys Restore VIP link loading state lost during merge Feb 11, 2026
Copilot AI requested a review from Yashb404 February 11, 2026 07:32
@Yashb404 Yashb404 marked this pull request as ready for review February 11, 2026 13:16
@Yashb404 Yashb404 merged commit 0ca6fb4 into feat/keys-fresh Feb 11, 2026
@Yashb404 Yashb404 deleted the copilot/sub-pr-116-please-work branch February 11, 2026 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants