Draft
Conversation
ref https://linear.app/ghost/issue/BER-3361/remove-feature-flag-release Moves the React members list onto /members, removes the rollout flag, and keeps a slim Ember shim for route compatibility while the dead Ember list code is cleaned up separately.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 23548060959 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/membersand remove themembersForwardrollout flag/membersas the permanent routeTest Plan
yarn workspace @tryghost/admin eslint src/layout/app-sidebar/nav-content.tsx src/layout/app-sidebar/nav-content.helpers.ts src/layout/app-sidebar/nav-content.helpers.test.ts src/layout/app-sidebar/member-sidebar-views.tsyarn eslint apps/admin-x-settings/src/components/settings/advanced/labs/private-features.tsx apps/posts/src/routes.tsx ghost/core/core/shared/labs.jsYARN_IGNORE_ENGINES=1 yarn eslint ghost/admin/tests/acceptance/members-test.js ghost/admin/tests/acceptance/members/import-test.js ghost/admin/tests/unit/services/state-bridge-test.js ghost/admin/app/controllers/members.js ghost/admin/app/routes/members.jsYARN_IGNORE_ENGINES=1 yarn ember-template-lint ghost/admin/app/templates/members.hbs ghost/admin/app/components/posts-list/list-item.hbsNotes
jonatan-ber-3361-ember-cleanup