Removed unnecessary measureElement from virtual scroll#26959
Removed unnecessary measureElement from virtual scroll#26959rob-ghost wants to merge 1 commit intober-3470-fix-massive-member-countsfrom
Conversation
The measureElement callback causes unnecessary re-measurements and layout thrashing when rendering large virtualized lists
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
E2E Tests FailedTo view the Playwright test report locally, run: REPORT_DIR=$(mktemp -d) && gh run download 23550380401 -n playwright-report -D "$REPORT_DIR" && npx playwright show-report "$REPORT_DIR" |
|
Closing this PR — the |
Summary
virtualizer.measureElementref from virtual scroll item props since all consumers use fixed-height rows (estimateSize: () => 72or default() => 100)virtualizerobject is already returned from the hook, so any future consumer needing dynamic measurement can accessvirtualizer.measureElementdirectlyBuilt on top of #26952 which fixes the scroll container resolution.
Test plan
yarn workspace @tryghost/posts test:unitpasses (114 tests)