Skip to content

Added comprehensive E2E snapshot tests for post analytics CSV export #26969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmraible wants to merge 2 commits into
base: main
Choose a base branch
from
+519 −1
Open

Added comprehensive E2E snapshot tests for post analytics CSV export #26969

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c8e203b
Added comprehensive E2E snapshot tests for post analytics CSV export
cmraible Mar 25, 2026
2ade949
Fixed non-deterministic ordering in post analytics CSV export
cmraible Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ghost/core/core/server/services/posts/posts-exporter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ class PostsExporter {
async export({filter, order, limit}) {
const posts = await this.#models.Post.findPage({
filter: filter ?? 'status:published,status:sent',
order,
order: order ?? 'published_at DESC, id DESC',
Copy link
Copy Markdown
Collaborator Author

@cmraible cmraible Mar 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a fallback ordering so the sort order of the CSV file is deterministic for snapshot tests

limit,
withRelated: [
'tiers',
Expand Down
Loading
Loading