Skip to content

Added gift to member status#26992

Open
mike182uk wants to merge 1 commit intomainfrom
mike-ber-3472-ghost-core-add-gift-member-status
Open

Added gift to member status#26992
mike182uk wants to merge 1 commit intomainfrom
mike-ber-3472-ghost-core-add-gift-member-status

Conversation

@mike182uk
Copy link
Copy Markdown
Member

ref https://linear.app/ghost/issue/BER-3472

Added gift status to member status enum so that the system can track and distinguish members with a gift subscription

ref https://linear.app/ghost/issue/BER-3472

Added `gift` status to member status enum so that the system can track and
distinguish members with a gift subscription
@github-actions github-actions bot added the migration [pull request] Includes migration for review label Mar 26, 2026
@github-actions
Copy link
Copy Markdown
Contributor

It looks like this PR contains a migration 👀
Here's the checklist for reviewing migrations:

General requirements

  • ⚠️ Tested performance on staging database servers, as performance on local machines is not comparable to a production environment
  • Satisfies idempotency requirement (both up() and down())
  • Does not reference models
  • Filename is in the correct format (and correctly ordered)
  • Targets the next minor version
  • All code paths have appropriate log messages
  • Uses the correct utils
  • Contains a minimal changeset
  • Does not mix DDL/DML operations
  • Tested in MySQL and SQLite

Schema changes

  • Both schema change and related migration have been implemented
  • For index changes: has been performance tested for large tables
  • For new tables/columns: fields use the appropriate predefined field lengths
  • For new tables/columns: field names follow the appropriate conventions
  • Does not drop a non-alpha table outside of a major version

Data changes

  • Mass updates/inserts are batched appropriately
  • Does not loop over large tables/datasets
  • Defends against missing or invalid data
  • For settings updates: follows the appropriate guidelines

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 26, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 33f6d0c7-78b9-4ab1-b534-b31c9740fa6b

📥 Commits

Reviewing files that changed from the base of the PR and between 0dfa0bb and a6df18c.

📒 Files selected for processing (1)
  • ghost/core/core/server/data/schema/schema.js

Walkthrough

This pull request extends the member status enumeration values in the database schema by adding a gift status option. The change updates three validation enums in the schema to include the new gift status alongside the existing free, paid, and comped statuses. The modifications affect member status validation and member status event tracking, allowing these fields to recognize and store the additional status value.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Added gift to member status' clearly and directly describes the main change in the changeset - adding a new 'gift' status value to member status enums.
Description check ✅ Passed The description is directly related to the changeset, explaining the purpose and motivation for adding the 'gift' status to the member status enum.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mike-ber-3472-ghost-core-add-gift-member-status

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

migration [pull request] Includes migration for review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants