Fixed unhandled promise rejection in Redis adapter _get timeout path#27007
Open
muratcorlu wants to merge 2 commits intoTryGhost:mainfrom
Open
Fixed unhandled promise rejection in Redis adapter _get timeout path#27007muratcorlu wants to merge 2 commits intoTryGhost:mainfrom
muratcorlu wants to merge 2 commits intoTryGhost:mainfrom
Conversation
When getTimeoutMilliseconds was configured, _get wrapped the cache read in a new Promise but did not handle rejections from the inner cache.get() call. If Redis rejected the command (e.g. with enableOfflineQueue: false), the rejection went unhandled, which crashes Ghost. Fixed by adding a .catch() that clears the timeout and resolves with null, treating a Redis error during a timed get as a cache miss.
|
muratcorlu
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When getTimeoutMilliseconds was configured, _get wrapped the cache read in a new Promise but did not handle rejections from the inner cache.get() call. If Redis rejected the command (e.g. with enableOfflineQueue: false), the rejection went unhandled, which crashes Ghost.
Fixed by adding a .catch() that clears the timeout and resolves with null, treating a Redis error during a timed get as a cache miss.
Got some code for us? Awesome 🎊!
Please take a minute to explain the change you're making:
Please check your PR against these items:
We appreciate your contribution! 🙏