Skip to content

🐛 Fixed theme uploads freezing when folders are read-only#28898

Merged
sagzy merged 1 commit into
mainfrom
fix/missing-perms-on-theme-upload
Jun 25, 2026
Merged

🐛 Fixed theme uploads freezing when folders are read-only#28898
sagzy merged 1 commit into
mainfrom
fix/missing-perms-on-theme-upload

Conversation

@sagzy

@sagzy sagzy commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

ref https://linear.app/ghost/issue/ONC-1838
ref TryGhost/framework#761
ref TryGhost/gscan#853

Theme uploads could hang without any visible error when a zip contained folders without sufficient write permissions. GScan needs to write into those folders while extracting and validating the theme.

Updated gscan to include the permission handling fix so missing permissions are restored during upload and the theme can be installed successfully instead of leaving the UI frozen.

ref https://linear.app/ghost/issue/ONC-1838/timøeout-on-theme-upload
ref TryGhost/framework#761
ref TryGhost/gscan#853

Theme uploads could hang without any visible error when a zip contained
folders without sufficient write permissions. GScan needs to write into
those folders while extracting and validating the theme.

Updated `gscan` to include the permission handling fix so missing
permissions are restored during upload and the theme can be installed
successfully instead of leaving the UI frozen.
@coderabbitai

coderabbitai Bot commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: f7b85428-139a-46a7-b1fa-cdd146771160

📥 Commits

Reviewing files that changed from the base of the PR and between 515c39b and fde6a3f.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • ghost/core/package.json

Walkthrough

The gscan dependency version in ghost/core/package.json was updated from 6.4.0 to 6.4.1.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing theme uploads freezing on read-only folders.
Description check ✅ Passed The description matches the changeset and explains the gscan permission fix for theme uploads.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/missing-perms-on-theme-upload

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jun 25, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix

Ensure the fix-ci command is configured to always run in your CI pipeline to get automatic fixes in future runs. For more information, please see https://nx.dev/ci/features/self-healing-ci


View your CI Pipeline Execution ↗ for commit fde6a3f

Command Status Duration Result
nx run-many --target=build --projects=tag:publi... ✅ Succeeded 2s View ↗
nx run-many -t test:unit -p ghost,@tryghost/adm... ✅ Succeeded 8m 47s View ↗
nx run ghost:test:ci:integration ✅ Succeeded 2m 41s View ↗
nx run @tryghost/admin-x-settings:test:acceptance ✅ Succeeded 7m 1s View ↗
nx run ghost:test:integration ✅ Succeeded 2m 33s View ↗
nx run @tryghost/admin:build ✅ Succeeded 4m 33s View ↗
nx run ghost-admin:test ✅ Succeeded 3m 12s View ↗
nx run ghost:test:legacy ✅ Succeeded 2m 12s View ↗
Additional runs (7) ✅ Succeeded ... View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-06-25 13:22:42 UTC

@sagzy sagzy enabled auto-merge (squash) June 25, 2026 13:15
@codecov

codecov Bot commented Jun 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.28%. Comparing base (b350f89) to head (fde6a3f).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #28898      +/-   ##
==========================================
- Coverage   74.28%   74.28%   -0.01%     
==========================================
  Files        1565     1568       +3     
  Lines      135098   135198     +100     
  Branches    16413    16415       +2     
==========================================
+ Hits       100363   100430      +67     
+ Misses      33751    33749       -2     
- Partials      984     1019      +35     
Flag Coverage Δ
admin-tests 55.16% <ø> (ø)
e2e-tests 76.42% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sagzy sagzy merged commit ae49fd0 into main Jun 25, 2026
49 checks passed
@sagzy sagzy deleted the fix/missing-perms-on-theme-upload branch June 25, 2026 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant