Skip to content

🐛 Fixed hover-reveal View more buttons staying hidden on keyboard focus #28929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dimitristrechas wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −6
Open

🐛 Fixed hover-reveal View more buttons staying hidden on keyboard focus #28929

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/posts/src/views/PostAnalytics/Overview/components/newsletter-overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ const NewsletterOverview: React.FC<NewsletterOverviewProps> = ({post, isNewslett
Newsletter performance
</CardTitle>
</CardHeader>
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-300 group-hover/datalist:translate-x-0 group-hover/datalist:opacity-100' size='sm' variant='outline' onClick={() => {
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-300 group-hover/datalist:translate-x-0 group-hover/datalist:opacity-100 focus-visible:translate-x-0 focus-visible:opacity-100' size='sm' variant='outline' onClick={() => {
navigate(`/posts/analytics/${postId}/newsletter`);
}}>View more</Button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion apps/posts/src/views/PostAnalytics/Overview/components/web-overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ const WebOverview: React.FC<WebOverviewProps> = ({chartData, range, isLoading, v
Web performance
</CardTitle>
</CardHeader>
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-300 group-hover/datalist:translate-x-0 group-hover/datalist:opacity-100' size='sm' variant='outline' onClick={() => {
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-300 group-hover/datalist:translate-x-0 group-hover/datalist:opacity-100 focus-visible:translate-x-0 focus-visible:opacity-100' size='sm' variant='outline' onClick={() => {
navigate(`/posts/analytics/${postId}/web`);
}}>View more</Button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion apps/posts/src/views/PostAnalytics/Overview/overview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,7 @@ const Overview: React.FC = () => {
Growth
</CardTitle>
</CardHeader>
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-200 group-hover:translate-x-0 group-hover:opacity-100' size='sm' variant='outline' onClick={() => {
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-200 group-hover:translate-x-0 group-hover:opacity-100 focus-visible:translate-x-0 focus-visible:opacity-100' size='sm' variant='outline' onClick={() => {
navigate(`/posts/analytics/${postId}/growth`);
}}>View more</Button>
</div>
Expand Down
2 changes: 1 addition & 1 deletion apps/posts/src/views/PostAnalytics/components/kpi-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const KpiCardValue: React.FC<React.HTMLAttributes<HTMLDivElement>> = ({ch

export const KpiCardMoreButton: React.FC<React.ComponentProps<typeof Button>> = ({children, className, ...props}) => {
return (
<Button className={cn('absolute right-4 top-4 z-50 hidden translate-x-10 text-black dark:text-white/80 dark:hover:text-white opacity-0 transition-all duration-200 group-hover:translate-x-0 group-hover:opacity-100 md:visible! md:block!', className)} size='sm' variant='outline' {...props}>
<Button className={cn('absolute right-4 top-4 z-50 hidden translate-x-10 text-black dark:text-white/80 dark:hover:text-white opacity-0 transition-all duration-200 group-hover:translate-x-0 group-hover:opacity-100 focus-visible:translate-x-0 focus-visible:opacity-100 md:visible! md:block!', className)} size='sm' variant='outline' {...props}>
{children}
</Button>
);
Expand Down
2 changes: 1 addition & 1 deletion apps/shade/src/components/patterns/kpi-card.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export const WithHoverButton: Story = {
/>
</div>
<Button
className='absolute right-6 translate-x-full opacity-0 transition-all duration-300 group-hover:translate-x-0 group-hover:opacity-100'
className='absolute right-6 translate-x-full opacity-0 transition-all duration-300 group-hover:translate-x-0 group-hover:opacity-100 focus-visible:translate-x-0 focus-visible:opacity-100'
size='sm'
variant='outline'
>
Expand Down
2 changes: 1 addition & 1 deletion apps/stats/src/views/Stats/Overview/components/overview-kpis.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ const OverviewKPICard: React.FC<OverviewKPICardProps> = ({
/>
</div>
{onClick &&
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-200 group-hover:translate-x-0 group-hover:opacity-100' size='sm' variant='outline' onClick={onClick}>View more</Button>
<Button className='absolute right-6 translate-x-10 opacity-0 transition-all duration-200 group-hover:translate-x-0 group-hover:opacity-100 focus-visible:translate-x-0 focus-visible:opacity-100' size='sm' variant='outline' onClick={onClick}>View more</Button>
}
</KpiCardHeader>
<CardContent>
Expand Down