Skip to content

Fix production image startup smoke test#747

Merged
JoeeGrigg merged 2 commits into
mainfrom
revert-vite-add-smoke-test
Jun 29, 2026
Merged

Fix production image startup smoke test#747
JoeeGrigg merged 2 commits into
mainfrom
revert-vite-add-smoke-test

Conversation

@JoeeGrigg

Copy link
Copy Markdown
Member

No description provided.

@JoeeGrigg JoeeGrigg requested a review from cmraible as a code owner June 29, 2026 12:25
@JoeeGrigg JoeeGrigg removed the request for review from cmraible June 29, 2026 12:25
@coderabbitai

coderabbitai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@JoeeGrigg, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 52 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4b2ce4a3-c0a6-4f4a-85a5-b9787ee3aafe

📥 Commits

Reviewing files that changed from the base of the PR and between d11c684 and 467c3d1.

📒 Files selected for processing (1)
  • .github/actions/docker-build/action.yml

Walkthrough

The Docker build composite action is updated to always set load: true for both base and production image builds, replacing a prior conditional. A new bash smoke test step is added after the production image build: it starts the container with port mapping, registers a cleanup trap, resolves the mapped host port via docker inspect, and polls the root path with curl up to 30 times, failing if the container exits early or readiness is not reached. Separately, the vite dev dependency is downgraded from 8.1.0 to 8.0.16 in package.json.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so there is nothing to evaluate against the changeset. Add a brief description of the intended change so it can be checked against the updated files.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change by focusing on the production image startup smoke test.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-vite-add-smoke-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/actions/docker-build/action.yml:
- Around line 105-107: The smoke test loop in the docker-build action can still
hang because the `curl` probe in the `for attempt in {1..30}` check has no
timeout. Update the `curl` invocation in this probe to use a bounded timeout so
each attempt fails fast if the container accepts the connection but never
responds, keeping the retry cap in `action.yml` effective.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e7d73d80-71e7-4a35-b5f6-a17da69b6b08

📥 Commits

Reviewing files that changed from the base of the PR and between 9a06b31 and d11c684.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (2)
  • .github/actions/docker-build/action.yml
  • package.json

Comment thread .github/actions/docker-build/action.yml
@github-actions

Copy link
Copy Markdown

✅ Deployed to staging (tree: bfd27b97648bcd89c083faefbb371d8645fc1b45)

@JoeeGrigg JoeeGrigg merged commit a3a8059 into main Jun 29, 2026
17 checks passed
@JoeeGrigg JoeeGrigg deleted the revert-vite-add-smoke-test branch June 29, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant