Skip to content

Update CI to test against Node 20, 22, 24 #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnONolan merged 1 commit into from
Feb 9, 2026
Merged

Update CI to test against Node 20, 22, 24 #129

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,14 @@ jobs:
lint:
runs-on: ubuntu-latest
if: github.event_name == 'push' || (github.event_name == 'pull_request' && !startsWith(github.head_ref, 'renovate/'))
strategy:
matrix:
node: [20, 22, 24]
Copy link

@cursor cursor bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Node matrix applied to lint-only job, no tests

Low Severity

The strategy matrix runs yarn lint three times (once per Node version), but ESLint results are Node-version-independent, making the extra runs redundant. The PR's stated goal is to "test against Node 20, 22, 24," yet there is no test script in package.json and no yarn test step in the workflow — so nothing actually validates runtime behavior across Node versions. The matrix triples CI cost with no added coverage.

Fix in Cursor Fix in Web

name: Node ${{ matrix.node }}
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: 18
node-version: ${{ matrix.node }}
- run: yarn
- run: yarn lint